[LG-5504] feat(input-box): add InputBoxContext
#3290
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…associated types and tests
|
shaneeza
changed the title
InputBoxContext InputBoxContext
shaneeza
requested review from
a team,
TheSonOfThomp and
stephl3
and removed request for
a team
Contributor
|
Size Change: +216 B (+0.01%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
stephl3
reviewed
Nov 7, 2025
Comment on lines
80
to
84
| return ( | ||
| segment: SegmentEnum[keyof SegmentEnum], | ||
| value: string, | ||
| allowZero?: boolean, | ||
| ): boolean => { |
Collaborator
There was a problem hiding this comment.
nit: could benefit from an object arg
|
|
||
| import { ExplicitSegmentRule } from '../utils'; | ||
|
|
||
| export const SegmentObjMock = { |
Collaborator
There was a problem hiding this comment.
wondering if this may also benefit from time mocks in addition to the date mocks
Collaborator
Author
There was a problem hiding this comment.
If I add time mocks, I think it would make more sense to add it in #3285, so I can adjust the current tests.
| @@ -0,0 +1 @@ | |||
| export { type InputSegmentChangeEventHandler } from './InputSegment.types'; | |||
Collaborator
There was a problem hiding this comment.
This will create a circular import between InputBoxContext and InputSegment. This could be addressed by having a shared.types.ts file for types like this change event handler type
Collaborator
Author
There was a problem hiding this comment.
This shouldn't be here; it was added by accident.
Comment on lines
9
to
17
| charsPerSegment: Record<Segment, number>; | ||
| disabled: boolean; | ||
| segmentEnum: SegmentEnumObject<Segment>; | ||
| onChange: InputSegmentChangeEventHandler<Segment, string>; | ||
| onBlur: (event: React.FocusEvent<HTMLInputElement>) => void; | ||
| segmentRefs: Record<Segment, ReturnType<DynamicRefGetter<HTMLInputElement>>>; | ||
| segments: Record<Segment, string>; | ||
| labelledBy?: string; | ||
| size: Size; |
Collaborator
There was a problem hiding this comment.
If any of these will be exposed by InputBox, they can also be shared in the shared.types.ts file
Any tsdocs worth adding?
Collaborator
Author
There was a problem hiding this comment.
Good call, these can be shared
Comment on lines
59
to
67
| expect(result.current.charsPerSegment).toBe(charsPerSegmentMock); | ||
| expect(result.current.segmentEnum).toBe(SegmentObjMock); | ||
| expect(result.current.onChange).toBe(mockOnChange); | ||
| expect(result.current.onBlur).toBe(mockOnBlur); | ||
| expect(result.current.segmentRefs).toBe(segmentRefsMock); | ||
| expect(result.current.segments).toBe(segmentsMock); | ||
| expect(result.current.size).toBe(Size.Default); | ||
| expect(result.current.disabled).toBe(false); | ||
| }); |
Collaborator
There was a problem hiding this comment.
nit: could destructure to DRY this up
This was referenced Nov 7, 2025
…se object parameter format for improved clarity and consistency
…ity by destructuring context values
stephl3
reviewed
Nov 10, 2025
| } from './InputBoxContext.types'; | ||
|
|
||
| // The Context constant is defined with the default/fixed type, which is string. This is the loose type because we don't know the type of the string yet. | ||
| export const InputBoxContext = createContext<InputBoxContextType | null>(null); |
Collaborator
There was a problem hiding this comment.
was there a final decision on naming this package/components ? Even thinking DateInputBox is a fine name considering it aligns with the Date web api which applies to both date and time
Collaborator
Author
There was a problem hiding this comment.
We briefly discussed the name InputBox, but it was never finalized, so I'm not opposed to changing the name.
As for DateInputBox, at first it made me think of only DatePicker because DateInputBox is a component within DatePicker, but, as you've just mentioned, the API aligns with both date and time, so this name makes sense.
Collaborator
Author
There was a problem hiding this comment.
Whatever we choose, I would prefer to update the component name after the chain of PRs has been merged. I can open a PR just for the name change.
Collaborator
There was a problem hiding this comment.
Gotcha, that sounds fine if that's easier than doing it now. Can we make a ticket to capture that work?
Collaborator
Author
There was a problem hiding this comment.
…utBoxTypes and remove deprecated InputSegment types
stephl3
reviewed
Nov 10, 2025
Comment on lines
1
to
5
| export type { | ||
| InputSegmentChangeEvent, | ||
| InputSegmentChangeEventHandler, | ||
| } from './InputSegment.types'; | ||
| export type { SharedInputBoxTypes } from './types'; |
Collaborator
There was a problem hiding this comment.
What is the reason not to consolidate these all in a single shared.types.ts file? I see that InputSegment.types.ts types are used in InputBoxContext.types.ts as well, so it seems like a premature split to make shared/types/ subdir. Why not just packages/input-box/src/shared.types.ts?
Collaborator
Author
There was a problem hiding this comment.
It was mainly just to make things a little more organized. If it's overkill, I can switch to shared.types.ts
…imports in InputBoxContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR is the first PR in a series of PRs that adds the new
InputBoxpackage and integrates it into the existingDatePickerpackage:InputSegment#3293InputBox#3285InputBoxcomponent #3286This PR adds
InputBoxContext, which will be used internally withinInputBoxandInputSegment.🎟 Jira ticket: LG-5504
✅ Checklist
For new components
🧪 How to test changes